Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MODULES-3158 (any string interpreted as SSLCompression on) #1398

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Fix MODULES-3158 (any string interpreted as SSLCompression on) #1398

merged 1 commit into from
Mar 23, 2016

Conversation

tpdownes
Copy link
Contributor

  1. Fix MODULES-3158 (any string interpreted as SSLCompression on)
  2. Convert ssl_honorcipherorder to boolean, backport accepting 'on' or 'off'

@tpdownes
Copy link
Contributor Author

It is worth mentioning that #1397 failed only because the build tests do not accept "SSLCompression on" but do accept "SSLCompression On". The documentation uses lower case and Apache accepts both cases for "(on|off)". I would have the module output more closely match the documentation and modify the build test here and elsewhere to more closely mimic either the documentation or Apache behavior.

But, in the interest of a single commit that passes the build test as written, I have provided this commit in response to Puppetlabs Ticket 3158.

@bmjen
Copy link
Contributor

bmjen commented Mar 23, 2016

This looks good. But can you update the README to indicate that the parameter now allows valid values of On, Off, true, false?

2. Convert ssl_honorcipherorder to boolean, backport strings 'on' or 'off'
3. Update documentation accordingly
@tpdownes
Copy link
Contributor Author

Documentation is for other people! I've updated the PR with what I think are necessary and useful updates to the relevant sections.

@bmjen
Copy link
Contributor

bmjen commented Mar 23, 2016

Thanks @tpdownes !

@bmjen bmjen merged commit 534e3aa into puppetlabs:master Mar 23, 2016
@igalic
Copy link
Contributor

igalic commented Mar 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants