Fix in custom fact "apache_version" for OracleLinux. #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom fact defined by lib/facter/apache_version.rb runs "apachectl -v" and applies the following regular expression: ^Server version: Apache\/([\w\.]+) \(([\w ]+)\) On OracleLinux 7.2, running apachectl -v produces the following output: Server version: Apache/2.4.6 () Server built: Nov 21 2015 05:34:59 The regex fails to match the output because it does not allow for nothing inside the parentheses. The following modified regex matches properly: ^Server version: Apache\/([\w\.]+) \(([\w ]*)\)
|
Thanks for your submission! Please add your test data to https://github.com/puppetlabs/puppetlabs-apache/blob/master/spec/unit/apache_version_spec.rb to avoid regressions on this in the future. |
|
@DavidS tests added |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom fact defined by lib/facter/apache_version.rb runs
"apachectl -v" and applies the following regular expression:
On OracleLinux 7.2, running apachectl -v produces the following output:
The regex fails to match the output because it does not allow
nothing inside the parentheses. The following modified
regex matches properly: