Passenger tuning with the apache::mod::passenger class #146
Conversation
|
bother. Includes changes from mod_shib work. |
|
Rebased! Now just the passenger tuning commits. |
|
This patch only implements a limited set of the Passenger declarations, but is sufficient to meet the requirements of the puppetmaster under |
|
Hi! We're reviewing this today as part of the Triage-a-Thon, and have a couple of comments:
Thank you! |
| $passenger_max_requests = undef, | ||
| $passenger_stat_throttle_rate = undef, | ||
| $rack_autodetect = undef, | ||
| $rails_autodetect = undef, |
There was a problem hiding this comment.
The equal signs should be aligned.
|
Ok, I've got some merges in the branch which are proving to be difficult to squash commits around. |
|
Re: squashing, my advice is to first get your master branch up to date with upstream master, and then do |
|
@sodabrew yes, that's what I'm doing, but hitting a lot of conflicts on the way doing the initial |
|
Ok, I think that's it. Need to try and trigger a Travis run... |
|
Awesome! Travis ran cleanly. Please let me know when you're ready for review and merge. |
|
Afraid not, I've broken something. Will have to wait until tomorrow, but at least now I just have to look at the diffs between a few commits. |
| @@ -242,7 +242,6 @@ | |||
| serveradmin => $serveradmin, | |||
| access_log_file => "ssl_${access_log_file}", | |||
| priority => '15', | |||
| } | |||
There was a problem hiding this comment.
yup. that was it.
|
Bingo. |
|
Awesome! Reviewing now! |
|
Awesome! You will probably still want to squash this into one commit though. I don't see a reason for multiple commits. |
…s a template to configure passenger. Matches standards in existing Apache module
|
Two should do, one for the functionality, another for the tests. |
| $rails_autodetect = undef, | ||
| $passenger_root = $apache::params::passenger_root, | ||
| $passenger_ruby = $apache::params::passenger_ruby, | ||
| $passenger_max_pool_size = undef, | ||
| ) { | ||
| apache::mod { 'passenger': } | ||
| # Template uses: $passenger_root, $passenger_ruby, $passenger_max_pool_size |
There was a problem hiding this comment.
Looks like this line should be updated to include the new variables.
|
Thanks for your work on this @Aethylred ! Very close to merging :) |
Passenger tuning with the apache::mod::passenger class
Some more of the supported params. Some are still missing where I don't know how they work.
This patch allows some tuning of Passenger and setting RackBaseURI in the vhost file.