-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-4213) Allow global rewrite rules inheritance in vhosts #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache module rewrite allows virtual hosts to inherit global rules if their conf files contain the directive "RewriteOptions Inherit" among rewrite rules This change includes this directive depending on a boolean parameter in apache::vhost class - rewrite_inherit - which defaults to false
Thanks @EmersonPrado ! Can you update the README and add a spec test for the new parameter? |
@bmjen I added a README and a spec test, but:
|
Found no way of making spec test work with file content included by Puppet template
@EmersonPrado No Problem! I will just squash it all, and I'll add something simple to the test case in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache module rewrite allows virtual hosts to inherit global rules
if their conf files contain the directive "RewriteOptions Inherit"
among rewrite rules
This change includes this directive depending on a boolean parameter
in
apache::vhost
class - rewrite_inherit - which defaults to false