Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-4213) Allow global rewrite rules inheritance in vhosts #1569

Merged
merged 7 commits into from
Dec 13, 2016

Conversation

EmersonPrado
Copy link
Contributor

Apache module rewrite allows virtual hosts to inherit global rules
if their conf files contain the directive "RewriteOptions Inherit"
among rewrite rules

This change includes this directive depending on a boolean parameter
in apache::vhost class - rewrite_inherit - which defaults to false

Apache module rewrite allows virtual hosts to inherit global rules
if their conf files contain the directive "RewriteOptions Inherit"
among rewrite rules

This change includes this directive depending on a boolean parameter
in apache::vhost class - rewrite_inherit - which defaults to false
@bmjen
Copy link
Contributor

bmjen commented Dec 12, 2016

Thanks @EmersonPrado ! Can you update the README and add a spec test for the new parameter?

@EmersonPrado
Copy link
Contributor Author

@bmjen I added a README and a spec test, but:

  1. I tend to overkill at READMEs. Feel absolutely free to criticize.
  2. I'm absolutely clueless on spec tests. I copied, pasted and edited what I think is right in the vhost defined type test. And I can't test it on my workstation, because it requires puppet-blacksmith, which is only installable by gem, and I'm behind a proxy. I just can't make it work. So I'll do some trial and error passes on this specs. Maybe I get something.

Emerson Prado added 2 commits December 13, 2016 15:50
Found no way of making spec test work with file content included by
Puppet template
@EmersonPrado
Copy link
Contributor Author

@bmjen Gave up completely on spec testing a file content added by template. I don't even know if spec tests can do that. How can I back off to commit 7d977e7?

@bmjen
Copy link
Contributor

bmjen commented Dec 13, 2016

@EmersonPrado No Problem! I will just squash it all, and I'll add something simple to the test case in a separate PR.

@bmjen bmjen merged commit 1a8a57f into puppetlabs:master Dec 13, 2016
@bmjen bmjen removed the needs-docs label Dec 14, 2016
@EmersonPrado EmersonPrado deleted the MODULES-4213 branch December 14, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants