Use enclose_ipv6 function from stdlib #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppetlabs-stdlib >= 4.12.0 merged the function `enclose_ipv6` of this module into their codebase. As this module includes `stdlib` it can be removed here.
hunner
added a commit
that referenced
this pull request
May 31, 2017
puppetlabs-stdlib merged the function `enclose_ipv6` of this module into their codebase in version 4.12.0 (puppetlabs/puppetlabs-stdlib@0378336). As this module includes `stdlib` it could be removed here. (this is why this commit bumps the dependency on `stdlib` to >= 4.12.0) Without this change every puppet run with a `stdlib` >= 4.16.0 will change the `enclose_ipv6.rb`-file back and forth between the version in `puppetlabs-stdlib` and the one in `puppetlabs-apache`. They diverged since commit puppetlabs/puppetlabs-stdlib@e2a8690 "(MODULES-4473) join strings for i18n parser".
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
puppetlabs-stdlib merged the function `enclose_ipv6` of this module into their codebase in version 4.12.0 (puppetlabs/puppetlabs-stdlib@0378336). As this module includes `stdlib` it could be removed here. (this is why this commit bumps the dependency on `stdlib` to >= 4.12.0) Without this change every puppet run with a `stdlib` >= 4.16.0 will change the `enclose_ipv6.rb`-file back and forth between the version in `puppetlabs-stdlib` and the one in `puppetlabs-apache`. They diverged since commit puppetlabs/puppetlabs-stdlib@e2a8690 "(MODULES-4473) join strings for i18n parser".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs-stdlib merged the function
enclose_ipv6of this module into their codebase in version 4.12.0 (puppetlabs/puppetlabs-stdlib@0378336). As this module includesstdlibit could be removed here.(this is why this commit bumps the dependency on
stdlibto >= 4.12.0)Without this change every puppet run with a
stdlib>= 4.16.0 will change theenclose_ipv6.rb-file back and forth between the version inpuppetlabs-stdliband the one inpuppetlabs-apache. They diverged since commit puppetlabs/puppetlabs-stdlib@e2a8690 "(MODULES-4473) join strings for i18n parser".