Ensure that ProxyPreserveHost is set even when ProxyPass (etc) are not. #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpdownes thanks for the PR! could you please rebase on master so it will run the newer travis config? |
Proxying can be enabled with the when the [P] flag is given to a RewriteRule, not only when ProxyPass is used.
|
I believe that 56e5800 should do it. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Ensure that ProxyPreserveHost is set even when ProxyPass (etc) are not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxying can be enabled when the [P] flag is given to a RewriteRule, not only when ProxyPass is used. In that instance, we may want to be able to set ProxyPreserveHost.