Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy_pass in directory template for location context #1644

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

toteva
Copy link
Contributor

@toteva toteva commented Jul 6, 2017

ProxyPass according to the https://httpd.apache.org/docs/2.4/mod/mod_proxy.html#proxypass is an available directive in the Location context

@toteva
Copy link
Contributor Author

toteva commented Jul 10, 2017

How can I rerun the checks? I see a strange error in the checks that " The Travis CI build failed" but watching at the logs, I did not see anything that really failed. Immediately after the failed tests the Ruby 2.1.7 was replaced in the gem with 2.1.9

ce8224a

@tphoney
Copy link
Contributor

tphoney commented Jul 10, 2017

I restarted the build, to see what happens

@toteva
Copy link
Contributor Author

toteva commented Jul 10, 2017

Thanks. The 2.1.7 seems to have passed.

@eputnam
Copy link
Contributor

eputnam commented Jul 19, 2017

@toteva thanks for the PR. can you rebase so we can run this against our new travis config?

@toteva
Copy link
Contributor Author

toteva commented Jul 24, 2017

The test with "export PUPPET_GEM_VERSION="~> 4.0" fails with 'The command "bundle exec rake release_checks" exited with 1.' But so it was the last time. There is no visible error. A rerun of the test fixed the problem.

Could you please rerun it or help me understand what I am doing wrong?

Thanks

@eputnam
Copy link
Contributor

eputnam commented Jul 24, 2017

i'm confused myself, i'll rekick though. let me know if you find anything.

@toteva
Copy link
Contributor Author

toteva commented Jul 25, 2017

Thanks. It has worked out. I do not know what could be causing this..

@eputnam eputnam merged commit 3127163 into puppetlabs:master Jul 25, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Add proxy_pass in directory template for location context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants