Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wsgi inclusion #1702

Merged
merged 2 commits into from
Sep 27, 2017
Merged

Wsgi inclusion #1702

merged 2 commits into from
Sep 27, 2017

Conversation

willmeek
Copy link

No description provided.

ekohl and others added 2 commits September 27, 2017 16:00
This copies the if statement around the wsgi concat fragment so mod_wsgi
is loaded if any option is used.
This commit will add unit tests to test the logic around
code changes which include the Apache wsgi module if a
number of options are set.
@ekohl
Copy link
Collaborator

ekohl commented Sep 27, 2017

Should I close #1693 since this includes it and adds tests?

@tphoney
Copy link
Contributor

tphoney commented Sep 27, 2017

we can close it when CI is better.

Copy link
Contributor

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just waiting on CI

@tphoney
Copy link
Contributor

tphoney commented Sep 27, 2017

This closes #1693

@tphoney tphoney merged commit 86995bf into puppetlabs:master Sep 27, 2017
@ekohl
Copy link
Collaborator

ekohl commented Sep 27, 2017

Thanks for adding tests @willmeek!

@willmeek
Copy link
Author

Thanks @ekohl !

@willmeek willmeek deleted the wsgi-inclusion branch September 28, 2017 08:40
@hunner hunner added the bugfix label Dec 6, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants