Added code to paramertize the libphp prefix #1852
Conversation
manifests/mod/php.pp
Outdated
| @@ -49,7 +50,7 @@ | |||
| $_package_name = undef | |||
| } | |||
|
|
|||
| $_lib = "libphp${php_version}.so" | |||
| $_lib = "$libphp_prefix${php_version}.so" | |||
There was a problem hiding this comment.
This should be using braces: ${libphp_prefix}
There was a problem hiding this comment.
I have now added the braces.
|
Can you also remove the executable bit from the file again? |
Sorry but I'm not sure what you mean by this? |
The file mode changed from 100644 → 100755 which means it's executable. This file shouldn't be. |
Apologies for this, I am using Windows Subsystem for Linux which changes my permissions in certain circumstances. I have now corrected this. |
Thank you :) |
|
this needs a rebase now :) |
|
@grahamuk2018 This change looks good to me. If you could rebase your work and add some documentation and test coverage I would feel happy to merge. |
grahamuk2018
force-pushed
the
parameterize-libphp
branch
2 times, most recently
from
a07150e to
12a5856
Compare
|
Hello @grahamuk2018 , |
manifests/mod/php.pp
Outdated
| @@ -57,7 +58,8 @@ | |||
| if $apache::version::scl_httpd_version { | |||
| $_lib = "librh-php${_php_version_no_dot}-php${_php_major}.so" | |||
| } else { | |||
| $_lib = "libphp${php_version}.so" | |||
| # Controls php version and libphp prefix | |||
|
Merging. All requirements have been met :-) and PR LGTM. |
This change allows libphp prefix in the $_lib variable to be changed as required. Currently I need to be able to set the value to libphp- as opposed to libphp.