Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod_dir, alias_icons_path, error_documents_path for CentOS 8 #2038

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

initrd
Copy link
Contributor

@initrd initrd commented Jun 12, 2020

Updating modules path, icons path, error documents path for CentOS 8. Without this patch, all the module .load and .conf files ended up in $confd_dir.

@initrd initrd requested a review from a team as a code owner June 12, 2020 16:41
@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 12 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@initrd initrd marked this pull request as draft June 12, 2020 17:31
@initrd initrd marked this pull request as ready for review June 12, 2020 17:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #2038 into master will increase coverage by 0.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   57.87%   58.49%   +0.61%     
==========================================
  Files          13       12       -1     
  Lines         235      212      -23     
==========================================
- Hits          136      124      -12     
+ Misses         99       88      -11     
Impacted Files Coverage Δ
lib/puppet/functions/apache/apache_pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache/bool2httpd.rb 0.00% <ø> (ø)
lib/puppet/functions/apache/pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache_pw_hash.rb 0.00% <0.00%> (ø)
lib/puppet/functions/bool2httpd.rb 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba8bcc...f1b9c4e. Read the comment docs.

@adrianiurca adrianiurca merged commit 6425cc4 into puppetlabs:master Jun 17, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
Update mod_dir, alias_icons_path, error_documents_path for CentOS 8
mwhahaha added a commit to mwhahaha/puppetlabs-apache that referenced this pull request Jul 26, 2021
This change updates the version handling to better future proof the
logic when newer versions are shipped. This should prevent having to add
things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
daveseff pushed a commit to daveseff/puppetlabs-apache that referenced this pull request Jul 19, 2022
This change updates the version handling to better future proof the
logic when newer versions are shipped. This should prevent having to add
things like puppetlabs#2063, puppetlabs#2021, puppetlabs#2038, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants