Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3-mod_wsgi instead of mod_wsgi on CentOS8 #2052

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Use python3-mod_wsgi instead of mod_wsgi on CentOS8 #2052

merged 1 commit into from
Jul 27, 2020

Conversation

kajinamit
Copy link
Contributor

@kajinamit kajinamit commented Jul 27, 2020

The mod_wsgi package was renamed to python3-mod_wsgi on CentOS8, and
now the old name doesn't work since the provides and obsoletes for it
was removed[1].

[1] https://centos.pkgs.org/8/centos-appstream-x86_64/python3-mod_wsgi-4.6.4-4.el8.x86_64.rpm.html

@kajinamit kajinamit requested a review from a team as a code owner July 27, 2020 05:13
@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

The mod_wsgi package was renamed to python3-mod_wsgi on CentOS8, and
now the old name doesn't work since the provides and obsoletes for it
was removed[1].

[1] https://centos.pkgs.org/8/centos-appstream-x86_64/python3-mod_wsgi-4.6.4-4.el8.x86_64.rpm.html
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9190834). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2052   +/-   ##
=========================================
  Coverage          ?   58.49%           
=========================================
  Files             ?       12           
  Lines             ?      212           
  Branches          ?        0           
=========================================
  Hits              ?      124           
  Misses            ?       88           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9190834...d346b76. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @kajinamit, this looks good and well documented! Thank you! Cheers!

Copy link
Contributor

@mwhahaha mwhahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have flipped this logic as when 9 comes out we'll have to update this again.

@kajinamit
Copy link
Contributor Author

@mwhahaha
I agree that it's better to update the default to avoid future effort, but there are some more places where we use default values for older releases and this is why I fixed only CentOS8 in this patch.
Note that to update the default we should be careful about Amazon Linux because Amazon Linux depends on the same logics but has completely different version assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants