Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - (feat) Add support for Puppet 7 #2101

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

daianamezdrea
Copy link
Contributor

@daianamezdrea daianamezdrea commented Dec 3, 2020

(feat) - Add support for Puppet 7
pdk version: 1.18.1

@daianamezdrea daianamezdrea requested a review from a team as a code owner December 3, 2020 14:41
@ekohl
Copy link
Collaborator

ekohl commented Dec 3, 2020

Feedback: as a user it's much clearer to read Suppert Puppet 7 in the subject than the vague Bump Puppet boundary.

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@e06785a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2101   +/-   ##
=======================================
  Coverage        ?   57.40%           
=======================================
  Files           ?       12           
  Lines           ?      216           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       92           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06785a...5c26cc5. Read the comment docs.

Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures unrelated to this change

@sanfrancrisko sanfrancrisko merged commit 9f9454d into main Dec 7, 2020
@sanfrancrisko sanfrancrisko deleted the pdksync_bump_puppet7 branch December 7, 2020 10:43
@sanfrancrisko sanfrancrisko changed the title pdksync - (feat) - Bump Puppet boundary (feat) Add support for Puppet 7 Dec 7, 2020
@sanfrancrisko sanfrancrisko changed the title (feat) Add support for Puppet 7 pdksync - (feat) Add support for Puppet 7 Dec 7, 2020
@sanfrancrisko
Copy link
Contributor

Feedback: as a user it's much clearer to read Suppert Puppet 7 in the subject than the vague Bump Puppet boundary.

@ekohl We're updating the PR titles so the CHANGELOG will show it as Add support for Puppet 7 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants