This allows an override of the default DirectoryIndex directive

[Aethylred]

Currently the DirectoryIndex directive is set globally usingthe dir.conf.erb template. This PR allows the default inclusive DirectoryIndex string to be changed.

Should we consider adding a DirectoryIndex override on apache::vhost?

[hunner]

This is a typo, @indexex.

Could you please have the template simply contain DirectoryIndex <%= @indexes.join(' ') %> since we can enforce constraints and defaults in the manifest instead?

[hunner]

Thanks for all of your submissions @Aethylred! If you could start the rspec-puppet coverage for the apache::mod::dir` class then that would be awesome! But I understand if not.

[Aethylred]

I've broken and fixed the spec tests for the default case :) ...now I just need to remember how to pass parameters for spec tests.

[hunner]

Actually the tests failing was correct, as the apache::mod::dir class is already declared in the apache::default_mods class and redeclaring it with parameters is a duplicate class declaration. This is kind of a problem because copy/pasting the apache::default_mods content isn't a great way to go, but I haven't come up with a better way to allow apache mod conditional loading without array subtraction.

[Aethylred]

I was suspecting something like that, Puppet being a declarative language and all. Each class declared only once.

...do you have a link to an example showing a working pattern for testing parametrised classes?

[hunner]

@Aethylred Your pattern is actually working! The tests are just failing because of the way apache::default_mods is written and will continue to fail until I can figure out how to conditionally exclude specific classes (like apache::mod::dir) from apache::default_mods.

Otherwise https://github.com/puppetlabs/puppetlabs-apache/blob/master/spec/classes/apache_spec.rb#L220 is probably a good example of multiple different parameters, including verifying one value that raises a Puppet::ParseError

[hunner]

If you're asking about how to make this work now, that would require setting a different :pre_condition for the context. Something like this:

      let :pre_condition do
        'class { "apache":
          default_mods => false,
        }'
      end

[hunner]

Oh, also if you could clean up your git history to be functionally descriptive before merging, that would be awesome :).

[Aethylred]

ugh, dragged in some commits from master.

[Aethylred]

Bother, now that I have learned this. It will be expected of me.

[hunner]

Haha! :)