Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10899) Load php module with the right libphp file #2166

Merged
merged 1 commit into from
Jul 16, 2021
Merged

(MODULES-10899) Load php module with the right libphp file #2166

merged 1 commit into from
Jul 16, 2021

Conversation

sheenaajay
Copy link
Contributor

@sheenaajay sheenaajay commented Jul 15, 2021

Request for a review
The configuration file is updated in the required format for php_version 8 (/etc/httpd/conf.modules.d/php.load)
LoadModule php_module modules/libphp.so
Unit tests are updated to reflect the change.

@puppet-community-rangefinder
Copy link

apache::mod::php is a class

Breaking changes to this file WILL impact these 49 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

This module is declared in 175 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sheenaajay sheenaajay marked this pull request as ready for review July 16, 2021 10:39
@sheenaajay sheenaajay requested a review from a team as a code owner July 16, 2021 10:39
Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@carabasdaniel carabasdaniel merged commit f50950a into puppetlabs:main Jul 16, 2021
@mxey
Copy link
Contributor

mxey commented Mar 25, 2022

This change breaks on Debian. The filename for libphp remains versioned, even for PHP 8. For example https://packages.debian.org/bookworm/amd64/libapache2-mod-php8.1/filelist contains /usr/lib/apache2/modules/libphp8.1.so, not /usr/lib/apache2/modules/libphp.so

@ekohl
Copy link
Collaborator

ekohl commented Mar 25, 2022

Please file a new issue and/or PR. Comments on old PRs generally get lost and don't lead to a resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants