(GH-iac-334) Remove code specific to unsupported OSs #2223
Conversation
apache::mod::fastcgi is a classthat may have no external impact to Forge modules. apache::mod::security is a classthat may have no external impact to Forge modules. apache::mpm is a typethat may have no external impact to Forge modules. apache::params is a classBreaking changes to this file WILL impact these 7 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):This module is declared in 174 of 579 indexed public
|
I think we should at least look at #2202. Either we should move forward or (my preference) we should remove the warnings. |
|
I would not be opposed to removing the warning, highly doubt the plan is going to be moved forward at this point as everyone involve with it is now gone to the best of my knowledge |
| @@ -98,17 +98,13 @@ | |||
| } | |||
|
|
|||
| if $mpm == 'prefork' { | |||
| if ( ( $::operatingsystem == 'Ubuntu' and versioncmp($::operatingsystemrelease,'18.04') >= 0 ) or $::operatingsystem == 'Debian' ) { | |||
There was a problem hiding this comment.
This is a change for non-Debian OSes. I think a closer match would be if $facts['osfamily'] == 'Debian'.
There was a problem hiding this comment.
Hey! Good spot. We will investigate asap!
There was a problem hiding this comment.
@ekohl The change should be fine as it is within the Debian section of the case $::osfamily started on line 50.
So it shouldn't effect any non Debian os's
There was a problem hiding this comment.
Ah good point. I'm not used to such long if/else. I just wondering if it should be restructured.
There was a problem hiding this comment.
Let's see what you think about #2227
Unsure of whether this should be merged now as the last release backwards incompatible and this will make two in a row.
In the event that it is we should ensure that as many of the community prs are brought into it as possible.