Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple scopes for Scope in Apache::OIDCSettings #2265

Merged
merged 8 commits into from
Sep 5, 2022
Merged

Allow multiple scopes for Scope in Apache::OIDCSettings #2265

merged 8 commits into from
Sep 5, 2022

Conversation

jjackzhn
Copy link
Contributor

Fixes #2262

@jjackzhn jjackzhn requested a review from a team as a code owner July 27, 2022 20:24
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@david22swan
Copy link
Member

@jjackzhn A fix for the spec tests has been merged in so the failures should resolve if you rebase

@jjackzhn
Copy link
Contributor Author

jjackzhn commented Aug 1, 2022

Just rebased.

david22swan
david22swan approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for taking so long to get back on the updated changes but this looks good to merge :)
Thanks for putting in the work.

@david22swan david22swan merged commit 87755cf into puppetlabs:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple scopes for Scope in Apache::OIDCSettings
4 participants
@jjackzhn @CLAassistant @david22swan @ia-content