Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring SecRequestBodyAccess and SecResponseBodyAccess #2272

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Allow configuring SecRequestBodyAccess and SecResponseBodyAccess #2272

merged 3 commits into from
Aug 4, 2022

Conversation

Vincevrp
Copy link
Contributor

No description provided.

@Vincevrp Vincevrp requested a review from a team as a code owner July 29, 2022 11:44
@puppet-community-rangefinder
Copy link

apache::mod::security is a class

that may have no external impact to Forge modules.

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Vincevrp Vincevrp force-pushed the modsec-bodyaccess branch from 2336118 to 4c7fc1c Compare July 30, 2022 21:55
@Vincevrp Vincevrp force-pushed the modsec-bodyaccess branch from 4c7fc1c to 3d9c5db Compare August 1, 2022 18:50
@Vincevrp
Copy link
Contributor Author

Vincevrp commented Aug 2, 2022

@david22swan tests have been added :)

david22swan
david22swan requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for on small thing

@Vincevrp Vincevrp force-pushed the modsec-bodyaccess branch from 44d476d to e3f10c8 Compare August 3, 2022 21:51
david22swan
david22swan approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for getting back on the change :)

@david22swan david22swan merged commit 568ffa0 into puppetlabs:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincevrp @david22swan @ia-content