Allow vhosts to have a string priority again #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
previously approved these changes
Aug 2, 2022
In f41251e the type was narrowed to no longer allow strings, but this can cause problems. Sorting is alphabetical and you need to format it for the correct sorting. So to make sure 2 loads before 10 you need to format it as 02. While the vhost can do some printf style magic to change 2 to 02, it must then also know what the highest number is. Otherwise 100 is sorted before 20. By allowing strings, you allow the caller to fix this. A type alias is introduced to reduce duplication and make it easier to track. Fixes: f41251e
ekohl
force-pushed
the
allow-string-priority-again
branch
from
e78e612 to
c11ab1f
Compare
|
Looks like I was not paying attention yesterday and failed to write proper tests for the type. Updated now. |
|
@david22swan this is blocking our CI pipelines. I'd appreciate it if this could get a look. |
|
Quick and easy merge. |
|
It certainly was quick :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f41251e the type was narrowed to no longer allow strings, but this can cause problems.
Sorting is alphabetical and you need to format it for the correct sorting. So to make sure 2 loads before 10 you need to format it as 02. While the vhost can do some printf style magic to change 2 to 02, it must then also know what the highest number is. Otherwise 100 is sorted before 20. By allowing strings, you allow the caller to fix this.
A type alias is introduced to reduce duplication and make it easier to track.
Fixes: f41251e