Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth_kerb and nss from Debian Bullseye #2281

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Aug 5, 2022

libapache2-mod-auth-kerb is unavailable in Debian Bullseye1
libapache2-mod-auth-kerb was removed in Debian Buster2

@ekohl ekohl requested a review from a team as a code owner August 5, 2022 12:23
@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 7 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@@ -34,6 +34,10 @@
end

shared_context 'a mod class, without including apache' do
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get rid of this, but it's out of scope for this PR.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Took a look and yeh, look's like the packages aren't included so happy to merge

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the syntax is fixed I mean

libapache2-mod-auth-kerb is unavailable in Debian Bullseye[1]
libapache2-mod-auth-kerb was removed in Debian Buster[2]

[1]: https://packages.debian.org/buster/libapache2-mod-auth-kerb
[2]: https://packages.debian.org/stretch/libapache2-mod-nss
@ekohl ekohl force-pushed the remove-removed-mods branch from d42c86b to 9044b4c Compare August 11, 2022 09:43
@ekohl
Copy link
Collaborator Author

ekohl commented Aug 11, 2022

I think the failure is unrelated. @david22swan mind having another look?

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david22swan david22swan merged commit b0fff67 into puppetlabs:main Aug 11, 2022
@ekohl ekohl deleted the remove-removed-mods branch August 11, 2022 13:43
@ekohl ekohl added the bugfix label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants