Add support for all proxy schemes, not just https://

[canth1]

This commit fixes #2285 by supporting all mod_proxy schemes according to the documentation here:

https://httpd.apache.org/docs/2.4/mod/mod_proxy.html

[ekohl]

Looks like the tests fail on this.

I also wonder if this should be a type alias.

[david22swan]

Looks like the tests fail on this.

I also wonder if this should be a type alias.

I would agree on this

[david22swan]

@canth1
Hey, look's like you've got a few failing tests

Also, think that @ekohl suggestion is a good one and that this would be a good use of a type alias to keep the code neater

[ekohl]

Small detail, but this looks good.

[ekohl]

Is it valid to not specify anything or should it be

Suggested change

	type Apache::ModProxyProtocol = Pattern[/(\A(ajp|fcgi|ftp|h2|h2c|http|https|scgi|uwsgi|ws|wss):\/\/.*\z)/, /(\Aunix:\/([^\n\/\0]+\/*)*\z)/]
	type Apache::ModProxyProtocol = Pattern[/(\A(ajp|fcgi|ftp|h2|h2c|http|https|scgi|uwsgi|ws|wss):\/\/.+\z)/, /(\Aunix:\/([^\n\/\0]+\/*)*\z)/]

[ekohl]

Looks like the tests are failing.

Also, it's possible to add tests for a type alias: https://rspec-puppet.com/documentation/type_aliases/

[canth1]

Is it valid to not specify anything or should it be

I don't think that's correct, because I took my regex directly from Stdlib:HTTPSUrl

https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/types/httpsurl.pp

Which is:

type Stdlib::HTTPSUrl = Pattern[/(?i:\Ahttps://.*\z)/]

[canth1]

Looks like the tests are failing.

Also, it's possible to add tests for a type alias: https://rspec-puppet.com/documentation/type_aliases/

Ok, I'll add the tests for this new type alias.

[ekohl]

Small detail, but this looks good.

I don't think that's correct, because I took my regex directly from Stdlib:HTTPSUrl

https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/types/httpsurl.pp

Which is:

type Stdlib::HTTPSUrl = Pattern[/(?i:\Ahttps://.*\z)/]

Interesting. That implies it also accepts https:// which doesn't make sense to me since I don't consider it an HTTP(S) URL.

[ekohl]

I don't think this is correct. The filename must match the type name.

[canth1]

Small detail, but this looks good.

I don't think that's correct, because I took my regex directly from Stdlib:HTTPSUrl
https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/types/httpsurl.pp
Which is:
type Stdlib::HTTPSUrl = Pattern[/(?i:\Ahttps://.*\z)/]

Interesting. That implies it also accepts https:// which doesn't make sense to me since I don't consider it an HTTP(S) URL.

Actually, you're correct. We shouldn't allow an empty value after ://

I'll fix that with your suggestion.

It looks like the Stdlib:HTTPSUrl allows that for some reason?

[ekohl]

It looks like the Stdlib:HTTPSUrl allows that for some reason?

Possibly an oversight and nobody ran into problems because of it.

[canth1]

The spec tests are failing, but I can't figure out why?

Resource type not found: Apache::ModProxyProtocol

Not sure why it's giving me that error?

[ekohl]

Because of #2289 (comment). You must name it according to the conventions so the loader finds it, so types/mod_proxy_protocol.pp.

[ekohl]

This looks good to me. @david22swan you requested changes, mind taking another look? Also, IMHO we should squash this on merge.

[david22swan]

LGTM

Everything look's good to me, only small comment is that the variables aren't aligned, but since there are only two of them it's not that big of a deal in my eyes.
Will go ahead with a squash merge.