Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated a2mod type/providers #2350

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

bastelfreak
Copy link
Collaborator

This type is deprecated, so it should be removed. I raise this PR so we won't forget to remove it. Please wait with merging until a new major release is planned.

This type is deprecated, so it should be removed. I raise this PR so we
won't forget to remove it. Please wait with merging until a new major
release is planned.
@bastelfreak bastelfreak requested a review from a team as a code owner December 6, 2022 11:47
@puppet-community-rangefinder
Copy link

a2mod is a type

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl
Copy link
Collaborator

ekohl commented Dec 6, 2022

In #2291 we gather that. Perhaps it should have been a milestone, but at least link it up.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
According to the changelog these where deprecated 9 years ago, so think it's about time we took them out.
Thanks for putting in the work :)

@david22swan david22swan merged commit e8ba891 into puppetlabs:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants