Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mod::proxy allow_from parameter inconsistency #2352 #2385

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

pebtron
Copy link
Contributor

@pebtron pebtron commented Feb 8, 2023

apache::mod::proxy allowed Stdlib::IP::Address as a class parameter, but proxy.conf.erb assumed it was an array.

apache::mod::proxy allowed Stdlib::IP::Address as a class parameter, but
proxy.conf.erb assumed it was an array.
@pebtron pebtron requested a review from a team as a code owner February 8, 2023 12:39
@puppet-community-rangefinder
Copy link

apache::mod::proxy is a class

Breaking changes to this file WILL impact these 16 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank's for catching this.
Looks like a good change to me

@david22swan david22swan merged commit e774bc7 into puppetlabs:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants