Don't set Allow from all by default for apache::vhost::directories

[RPDiep]

Do not to set Allow from all when either Deny from all is set or allow is set empty or false in apache::vhost::directories

[apenney]

This is probably nitpicking but can we reverse these to be:

and ! directory['allow'].include?([ false, 'false', '' ])

Mostly just as I find it confusing to read in reverse. :)

[igalic]

+1

[RPDiep]

As I understand, directory['allow'].include?([ false, 'false', '' ]) is not correct in ruby.
As directory['allow'] is likely to be a string, the include? method only accepts a string as parameter. (Please correct me if I'm wrong here.)
I will however put parentheses around directory['allow'] for clarity's sake.

[igalic]

Another way to express this differently in ruby would be to check for an intersection:

<%- f = [ false, :false, 'false', ''] -%
<%- if ( [directory['allow']] & f ) == [directory['allow']] -%>

We create an array f with all valid values for false. This way we can now short-circuit the check whether directory['allow'] is set or not, since nil is not part of f. Witness:

irb(main):001:0> f = [ false, :false, 'false', '' ]
=> [false, :false, "false", ""]
irb(main):002:0> ( f & [directory['allow']]) == [directory['allow']]
NameError: undefined local variable or method `directory' for main:Object
        from (irb):2
        from /usr/bin/irb:12:in `<main>'
irb(main):004:0> directory = {}
=> {}
irb(main):005:0> ( f & [directory['allow']]) == [directory['allow']]
=> false
irb(main):008:0> directory = { 'allow' => false }
=> {"allow"=>false}
irb(main):009:0> ( f & [directory['allow']]) == [directory['allow']]
=> true
irb(main):010:0>

This other way to express the same intent may not necessarily be a better way ;)

[igalic]

could you please amend your commit message to be a little more descriptive than "fix for link to $issue-tracker-link'

i.e.: What does this change do? (and if it is interesting enough, how does it do that?)

[igalic]

Hey, @RPDiep,

could you please rebase, squash these commits and make the commit message a bit easier to understand. Please see our CONTRIBUTING

[RPDiep]

Yes, I will do that. Expect it tomorrow.

[RPDiep]

Rebased and squashed as requested.