Support environment variable control for CustomLog

[chieping]

I tried to test, refering to CONTRIBUTING.md. Though I failed rake spec:system spec.

Could you tell me if testing command changed?

Thanks.

[igalic]

Nope, can't do that without any error output

[chieping]

@igalic Excuse me, the command I tried and error output is following.

$ bundle exec rake spec:system
rake aborted!
Don't know how to build task 'spec:system'

(See full trace by running task with --trace)

[igalic]

... that makes sense. We've upgraded to beaker... now I need to find out how to run those tests.
rake spec (obviously?) doesn't.
rspec spec/acceptance/*.rb however, fails with:

/usr/lib/ruby/1.9.1/rubygems/custom_require.rb:55:in `require': cannot load such file -- specinfra (LoadError)
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
        from /var/lib/gems/1.9.1/gems/beaker-rspec-2.0.0/lib/beaker-rspec/helpers/serverspec.rb:2:in `<top (required)>'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:55:in `require'
        from /var/lib/gems/1.9.1/gems/beaker-rspec-2.0.0/lib/beaker-rspec/spec_helper.rb:2:in `<top (required)>'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:60:in `require'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:60:in `rescue in require'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:35:in `require'
        from /home/igalic/src/puppet/puppetlabs-apache/spec/spec_helper_acceptance.rb:1:in `<top (required)>'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
        from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
        from /home/igalic/src/puppet/puppetlabs-apache/spec/acceptance/basic_spec.rb:1:in `<top (required)>'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/configuration.rb:896:in `load'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/configuration.rb:896:in `block in load_spec_files'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/configuration.rb:896:in `each'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/configuration.rb:896:in `load_spec_files'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/command_line.rb:22:in `run'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/runner.rb:80:in `run'
        from /var/lib/gems/1.9.1/gems/rspec-core-2.14.7/lib/rspec/core/runner.rb:17:in `block in autorun'

[igalic]

See #529

[blkperl]

This pull request no longer merges cleanly, please rebase against master.

[igalic]

So! I just tested this, and it looks all right.

bundle update
rspec spec/acceptance

But I just realized that I'm very unhappy with the choice of your variable name: Would you very much mind renaming $access_log_environment_variable to $access_log_env_var ?
The httpd documentation calls it that too, most of the time, so let's just roll with it.

[chieping]

Thank you very much for updating document and your opinion!
Added commit.

[igalic]

This looks very good now, and travis is happy!

Please squash the two commits down to one.

[chieping]

Yes, now squashed. Thanks!