Fix $ports_file reference in Namevirtualhost. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2013 19:40
This define was pointing at the params::ports_file version of the variable, rather than the one defined in the main class, making it impossible to correctly override.
This was pointing at ::params::ports_file instead of the main class, causing relocation of the ports file to fail.
hunner
added a commit
that referenced
this pull request
Dec 13, 2013
Fix $ports_file reference in Namevirtualhost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This define was pointing at the params::ports_file version of the
variable, rather than the one defined in the main class, making it
impossible to correctly override.