Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for mod_include #543

Merged
merged 1 commit into from
Dec 19, 2013
Merged

Added support for mod_include #543

merged 1 commit into from
Dec 19, 2013

Conversation

derJD
Copy link
Contributor

@derJD derJD commented Dec 19, 2013

No description provided.

igalic added a commit that referenced this pull request Dec 19, 2013
Added support for mod_include
@igalic igalic merged commit 03a38fa into puppetlabs:master Dec 19, 2013
@mbrodala
Copy link

I was under the assumption that one can include arbitrary modules anyways, even if there was no explicit apache::mod entry. The latter is only necessary in case some additional files or work are required. Am I wrong?

@derJD
Copy link
Contributor Author

derJD commented Dec 19, 2013

puppetlabs-apache wasn't able to enable/use mod_include without these modifications. On one hand it would be a nice feature to include arbitrary modules on the other hand, it could cause apache to crash if $module doesn't exist.
vhost_alias, python, perl and some other modules doesn't require additional files either.

@derJD derJD deleted the include branch December 19, 2013 22:56
@mbrodala
Copy link

FWIW, I can successfully include mod_include, even before this change. In fact, it's part of my default_mods.

@igalic
Copy link
Contributor

igalic commented Dec 20, 2013

Not when you modify those..

@mbrodala
Copy link

What do you mean by that? Modify the list of default_mods? Modify Apache modules?

traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
…windows_version

feature/match_docker_windows_version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants