Add support for SetHandler directive

[bodgit]

This PR adds support for the SetHandler directive for directories/files/locations. I needed to be able to selectively disable a handler for certain locations, like so:

<Location "/content/">
  SetHandler None
</Location>

etc.

[blkperl]

Can you add some spec tests?

[bodgit]

I've added a test but running the suite is made difficult by Vagrant failing to run, possibly because I'm using Fusion instead of Virtualbox, although I do have the custom provider installed. I get:

$ bundle exec rspec spec/acceptance
Hypervisor for centos-64-x64 is vagrant
Beaker::Hypervisor, found some vagrant boxes to create
/opt/local/lib/ruby1.9/gems/1.9.1/gems/beaker-1.6.2/lib/beaker/hypervisor/vagrant.rb:164:in `block (2 levels) in vagrant_cmd': Failed to exec 'vagrant destroy --force' (RuntimeError)
    from /opt/local/lib/ruby1.9/1.9.1/open3.rb:208:in `popen_run'
    from /opt/local/lib/ruby1.9/1.9.1/open3.rb:90:in `popen3'
    from /opt/local/lib/ruby1.9/gems/1.9.1/gems/beaker-1.6.2/lib/beaker/hypervisor/vagrant.rb:159:in `block in vagrant_cmd'
…

If I cd to where the Vagrantfile is I can customise and override it with enough Fusion-fu that I can manually do vagrant up --provider=vmware_fusion and I get a VM but I can't get the tests to run.

[bodgit]

I had to manually edit spec/acceptance/nodesets/centos-64-x64.yml to specify a Fusion-compatible .box file and then setting VAGRANT_DEFAULT_PROVIDER=vmware_fusion before running the tests gets me a working VM.

However, the test suite fails if Vagrant can't first destroy a VM called centos-64-x64 so I have to manually create the VM from the Vagrantfile, then run the tests which promptly destroys it and then recreates it. The code doesn't handle the case where the VM does not yet exist, (because this is the first time I've ran the tests).

After all that, I got zero failures.

[igalic]

@bodgit that seems like a bit of an usability issue with beaker which we should really work out with the team.

[bodgit]

@igalic sure, it looked like something deep within the beaker gem rather than this module, I suspect I'm in a minority using Vagrant with VMware so it's probably a less trodden path.

Anyway, the travis CI has had better luck at running the tests :-)

[igalic]

Yeah... because it's not running them :( (yet… Eventually, we'll move this over to Jenkins)

Btw, I've seen this specific error "fixed" in beaker already: voxpupuli/beaker#145 already, but it's not merged yet.

[bodgit]

Rebased with acceptance tests, ok?

[bodgit]

Bueller?

[igalic]

@bodgit I'm very sorry this got lost :(
Could you please rebase again?

[bodgit]

Done, bundle exec rspec spec/acceptance passes.

[igalic]

The travis failure is due to travis, we have a fix for this in puppet-gitlab: sbadia/puppet-gitlab#135

[apenney]

Can we get you to give this a quick rebase on master for us, just so we can be sure the travis checks pass?

[bodgit]

Sorry, completely forgot to do this. Rebased now.