Add WSGIApplicationGroup and WSGIImportScript directives #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some spec tests? Thanks. |
|
This no longer merges cleanly, please rebase this branch against master. Thanks. |
|
Done. The tests do pass, the error bombed on a couple of the Puppet/Ruby permutations for taking longer than 50 mins to complete, but a couple of them succeeded. |
|
We're still missing spec/acceptance tests… |
|
Anything else needed here? The Travis CI build errors are again because some permutations time out after 50 minutes. |
|
The only thing left is aesthetics. Can you please squash the "stray comma" commit? |
|
Done |
igalic
added a commit
that referenced
this pull request
Feb 11, 2014
Add WSGIApplicationGroup and WSGIImportScript directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the two WSGI options I was missing, might go part way to chipping at #476.