Add fcgid options

[ekohl]

This adds fcgid.conf to configure the fcgid module. It also adds the
FcgidWrapper option to vhost's directories.

The vhost option lacks any validation and allows users to shoot themselves in
the foot, but without iteration from the puppet future parser I don't see a
way to add the validation. Iteration would also allow auto including
apache::mod::fcgid.

[ekohl]

Failure from Travis:

/home/travis/build/puppetlabs/puppetlabs-apache/spec/classes/apache_spec.rb:154: warning: regexp has invalid interval
/home/travis/build/puppetlabs/puppetlabs-apache/spec/classes/apache_spec.rb:154: warning: regexp has `}' without escape
/home/travis/build/puppetlabs/puppetlabs-apache/spec/classes/apache_spec.rb:154: warning: regexp has invalid interval
/home/travis/build/puppetlabs/puppetlabs-apache/spec/classes/apache_spec.rb:154: warning: regexp has `}' without escape
/home/travis/.rvm/gems/ree-1.8.7-2012.02/gems/json-1.8.1/lib/json/ext/parser.so: [BUG] Segmentation fault
ruby 1.8.7 (2013-06-27 MBARI 8/0x6770 on patchlevel 374) [x86_64-linux], MBARI 0x6770, Ruby Enterprise Edition 2012.02

I think this is unrelated to my change. In puppet-foreman we set the 1.8.7 ruby explicitly to MRI in theforeman/puppet-foreman@93fb9b4 to avoid REE.

[igalic]

Thank you very much for your contribution, @ekohl!
The only thing this is missing is an update to the README.

[ekohl]

@igalic Added some documentation in the README.

[apenney]

This looks great! The only thing missing is the lack of a beaker acceptance test. Could you take a look in spec/acceptance and copy and tweak one of the existing tests to cover this? Thanks!

[igalic]

heheh...

._.

I hope that when @ekohl adds a new commit there won't be a third contributor coming along, saying,

"This looks fantastic, the only thing that's missing now …"

[ekohl]

Updated. @igalic Let's see if someone now says 'I like these RH tests, but where are the debian ones'.

[igalic]

@ekohl I guess if someone wants to go through the pain of supporting all platforms, they are welcome to submit their own pr.

---

A general observation here:

A puppet module is supposed to abstract away the need to consider differences between platforms.

A puppet module test then undoes all that process, by exposing all the guts, and being retracing all the steps.

I'm not sure we're doing testing right.

[ekohl]

@igalic I think tests can be written to share some things. Maybe it would be better to have a switch statement per testcase if there's platform specifics (httpd must be running vs apache2). Doing a curl to localhost could be shared since that part is platform independent. In the end you must test the guts here because that's what you are abstracting away from the user, but not every test is platform specific.

Does that make sense?

[igalic]

heh, yeah, does. Thanks for the sliver of hope ;)