Implement php_value and php_flag

[jweisner]

MODULES-1320 php_value option not available

[igalic]

@jweisner the main reason i didn't implement php_value|php_flag is that they can be overwritten in .htaccess, or in the app itself, so i'm finding it not really all that useful from an admin point of view

i might have explicitly stated that as such, somewhere. in an issue tracker that no longer exists…

[jweisner]

A lot of the configuration options available in the puppetlabs-apache module could be set with .htaccess directives, and php options could also be set in php.ini. When I saw php_admin_value was an option I naturally assumed php_value was as well.

The use-case for "non-admin" PHP options in the server config is that different virtual hosts often need different "reasonable defaults" for things like include_path.

The larger issue here seems to be that adding every configuration option exposed by every module will spiral out of control rather quickly, and I'm not sure how to solve this. Maybe the right thing to do is abstract away all non-core directives into something more generic? I don't find custom_fragment to be an elegant solution, but maybe I'm doing it wrong?

[igalic]

my beef, in this particular instance here, is with .htaccess.
if you control the application configuration, you should _not_ use .htaccess.
it opens up a whole can of worms of security and performance issues.

but, yes, adding more and more and more directives to vhost isn't going to be the solution.
i'm still hoping for a peaceful hour or so to sit down with @mhaskel and design a better one.

[bschonec]

I'm not asking for EVERY variable to be available, just that I can add "php_value " to the apache .conf file. I think it would be easy just to make a (two dimensional?) array where I can just dump the value of the array into the puppet manifest's variable.

I do think it's important to be able to control the conf file from your puppet module. I realize the security implications of overwriting the values with .htaccess but IMHO making the apache admin search in multiple places for configuration options makes things more difficult.

[cubiclelord]

I have a use case for allowing php_value. We set a basic include path via php_value, but allow our web developers in their code to append other includes as well. I assume they do this so we don't have to change our include path in Puppet every time they want to add another include path.

I am currently using custom_fragment to get around this, but it would be nice if we didn't have to.

[Spechal]

Things like NewRelic can use php_value values in a vhost

+1 for need

[underscorgan]

@jweisner thanks for the contribution!