'allow_encoded_slashes' vhost parameter was omitted #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if $allow_encoded_slashes { | ||
| concat::fragment { "${name}-allow_encoded_slashes": | ||
| target => "${priority_real}-${filename}.conf", | ||
| order => 50, |
There was a problem hiding this comment.
49 would not have been an option?
There was a problem hiding this comment.
It would have, of course, but since this parameter has obviously been
forgotten during the switch from the previous layout I preferred to follow
the strict order already in place.
Antoine
|
Can you please rebase and squash this down to a single commit? Otherwise, 👍 |
igalic
added a commit
that referenced
this pull request
Nov 13, 2014
'allow_encoded_slashes' vhost parameter was omitted
|
thanks @TONI0 \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_encoded_slashesvhost parameter was omitted when transitioning the vhost ERB template to concat fragments