MODULES-1688: fix indenting in vhost/_directories.erb template #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <<%= provider %> "<%= path %>"> | ||
| <%- if directory['headers'] -%> | ||
| <%- Array(directory['headers']).each do |header| -%> | ||
| <<%= provider %> "<%= path %>"> |
There was a problem hiding this comment.
I believe this line is indented 2 spaces two far. It should not follow ruby's indentation as it is part of the output, and correctly formatted output trumps ruby indentation.
There was a problem hiding this comment.
You are correct, fix coming in a few
jlambert121
force-pushed
the
1668_indenting
branch
from
a1bb9c4 to
799c179
Compare
|
Whoops, sorry I didn't catch this in time and now it has a conflict. Could you rebase for merge? Thanks! |
jlambert121
force-pushed
the
1668_indenting
branch
from
799c179 to
16e2a0d
Compare
hunner
added a commit
that referenced
this pull request
Jan 22, 2015
MODULES-1688: fix indenting in vhost/_directories.erb template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.