MODULES-1684: Specify mod_proxy_connect module for Apache >= 2.3.5 #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_proxy_connect was moved to own module since Apache >= 2.3.5. AllowCONNECT directive won't work without this module on Ubuntu 14.04 or Debian 8. Signed-off-by: Sergii Golovatiuk <[email protected]>
openstack-gerrit
pushed a commit
to openstack-archive/fuel-library
that referenced
this pull request
Jan 22, 2015
AllowCONNECT directive is implemented by mod_proxy_connect since Apache 2.3.5 Therefore this module must be enabled before using the AllowCONNECT directive. Otherwise apache refuses to start due to invalid configuration command. blueprint support-ubuntu-trusty Closes-Bug: #1412347 Puppet Labs Ticket: https://tickets.puppetlabs.com/browse/MODULES-1684 Pull Request: puppetlabs/puppetlabs-apache#987 Change-Id: I3777b328e919a0955639ded213fd314ad55d8146 Signed-off-by: Sergii Golovatiuk <[email protected]>
| class apache::mod::proxy_connect ( | ||
| $apache_version = $::apache::apache_version, | ||
| ) { | ||
| if versioncmp($apache_version, '2.4') >= 0 { |
There was a problem hiding this comment.
i'm confused. this means we "succeed" to "load" this module?
shouldn't we fail here?
There was a problem hiding this comment.
We shouldn't fail here. If we succeed then we should load module
igalic
added a commit
that referenced
this pull request
Feb 6, 2015
MODULES-1684: Specify mod_proxy_connect module for Apache >= 2.3.5
|
okay, thanks @holser! |
|
@hunner just drew my attention to MODULES-1874 so i checked httpd's svn history, and, mod_proxy_connect has been around since 2005, and is|was definitely in 2.2. we have to remove that whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_proxy_connect was moved to own module since Apache >= 2.3.5.
AllowConnect directive won't work without this module on Ubuntu 14.04 or
Debian 8.