improve skill search feedback #803
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of no_results
nevio18324
force-pushed
the
feature/improve-skill-search-feedback
branch
from
5a6120a to
bacd022
Compare
ManuelMoeri
requested changes
Feb 24, 2025
| @@ -14,10 +14,10 @@ | |||
| expect(response.body).to include("Bob Anderson") | |||
| end | |||
|
|
|||
| it 'should return no results if skill id is not given' do | |||
| it 'should return add skill to search if skill id is not given' do | |||
There was a problem hiding this comment.
Maybe write 'Should return add skill to search message if skill id is not given'? I think this would be a bit more clear.
| expect(page).to have_select("skill_id[]", selected: "Rails", visible: false) | ||
| expect(page).to have_field("level[]", with: 3) | ||
| expect(page).to have_field("interest[0]", with: 5, visible: false) | ||
| end | ||
|
|
||
| it 'Should return no results if skill id is not set' do | ||
| visit people_skills_path({level: [3], "interest[0]": 5}) | ||
| it 'Should return add skill to search if skill id is not set' do |
config/locales/de.yml
Outdated
| no_results: Keine Resultate | ||
| no_skill: Keine Resultate gefunden, fügen sie einen Skill zur Suche hinzu. |
There was a problem hiding this comment.
Following thing to think about: Do we ever use 'Sie' or any pronoun in the other messages? If no, we probably should just use 'Keine Resultate gefunden, füge einen Skill zu der Suche hinzu'.
(If you need to change it, do it for every language 🔢 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.