Prs/scheduler prioritization container info #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
commented
Jan 24, 2022
dsiganos
commented
- Removed need for friends functions.
- Added test case.
pwojcikdev
merged commit 9b6b860
into
pwojcikdev:prs/scheduler-prioritization-container-info
|
Thanks a lot for improving my changes. Just a quick question about using friend method, I noticed it’s the convention in the rest of the code. It’s not very important imo but was there any technical reason or just a legacy way of doing stuff? |
|
I do not know the reason for using friend in the other instances but it seems like a needless complication. |
pwojcikdev
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.