refactor: extract GUI-specific logic to GUI folders #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit of a reversal of #75 ... but probably much better than the state of things before #75.
basically: trying to get all the gui-specific stuff back into their own folders. This creates a base NDVapp class that GUI frameworks have to implement to be supported. (its the same as the current
GUIProvider
object).it does move a little bit of logic for each framework back into
_app.py
, mostly the "is_running" logic. but by having just that logic there, it allows all the rest to go back to the proper folderthis also fixes a bug wherein if you explicitly use
NDV_GUI_FRONTEND=qt
inside a jupyter notebook. it still doesn't let you use a Qt widget.