Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Better Styles for wx and jupyter widgets #88

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jan 12, 2025

Jupyter

before

Screenshot 2025-01-12 at 6 38 02 PM

after

Screenshot 2025-01-12 at 6 37 37 PM

wx

before

Screenshot 2025-01-12 at 6 38 59 PM

after

Screenshot 2025-01-12 at 6 39 25 PM

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (528e71b) to head (287be3d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/views/_jupyter/_array_view.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   70.45%   71.85%   +1.39%     
==========================================
  Files          44       44              
  Lines        4255     4274      +19     
==========================================
+ Hits         2998     3071      +73     
+ Misses       1257     1203      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 60e985a into pyapp-kit:main Jan 12, 2025
50 checks passed
@tlambert03 tlambert03 deleted the styles branch January 12, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant