PYBIND11_OBJECT_CVT should use namespace for error_already_set()

include/pybind11/pytypes.h

@@ -1038,12 +1038,12 @@ public:
     Name(const object &o)                                                                         \
         : Parent(check_(o) ? o.inc_ref().ptr() : ConvertFun(o.ptr()), stolen_t{}) {               \
         if (!m_ptr)                                                                               \
-            throw error_already_set();                                                            \
+            throw ::pybind11::error_already_set();                                                \
     }                                                                                             \
     /* NOLINTNEXTLINE(google-explicit-constructor) */                                             \
     Name(object &&o) : Parent(check_(o) ? o.release().ptr() : ConvertFun(o.ptr()), stolen_t{}) {  \
         if (!m_ptr)                                                                               \
-            throw error_already_set();                                                            \
+            throw ::pybind11::error_already_set();                                                \
     }
 
 #define PYBIND11_OBJECT_CVT_DEFAULT(Name, Parent, CheckFun, ConvertFun)                           \

tests/test_pytypes.cpp

@@ -11,6 +11,38 @@
 
 #include <utility>
 
+
+
+namespace external {
+    namespace detail {
+	bool check(PyObject *o) { return PyFloat_Check(o) != 0; }
+
+	PyObject *conv(PyObject *o) {
+	    if (PyLong_Check(o)) {
+		double v = PyLong_AsDouble(o);
+		if (v == -1.0 && PyErr_Occurred()) {
+		    return nullptr;
+		}
+		return PyFloat_FromDouble(v);
+	    } else {
+		PyErr_SetString(PyExc_TypeError, "Unexpected type");
+		return nullptr;
+	    }
+	}
+
+	PyObject *default_constructed() {
+	    return PyFloat_FromDouble(0.0);
+	}
+    }
+    class float_ : public py::object {
+	PYBIND11_OBJECT_CVT(float_, py::object, external::detail::check, external::detail::conv)
+
+	float_() : py::object(external::detail::default_constructed(), borrowed_t{}) {}
+
+	double get_value() const { return PyFloat_AsDouble(this->ptr()); }
+    };
+}
+
 TEST_SUBMODULE(pytypes, m) {
     // test_bool
     m.def("get_bool", [] { return py::bool_(false); });
@@ -545,4 +577,6 @@ TEST_SUBMODULE(pytypes, m) {
         py::detail::accessor_policies::tuple_item::set(o, (py::size_t) 0, s0);
         return o;
     });
+
+    m.def("square_float_", [](external::float_ x) -> double { double v = x.get_value(); return v*v; });
 }

tests/test_pytypes.py

@@ -634,3 +634,8 @@ def test_implementation_details():
     assert m.tuple_item_set_ssize_t() == ("emely", "edmond")
     assert m.tuple_item_get_size_t(tup) == 93
     assert m.tuple_item_set_size_t() == ("candy", "cat")
+
+
+def test_external_float_():
+    r1 = m.square_float_(2.0)
+    assert r1 == 4.0