Fix strict behavior for unions #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1638 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Feb 24, 2025
sydney-runkle
commented
Feb 24, 2025
src/url.rs
Outdated
| @@ -400,7 +400,7 @@ impl PyMultiHostUrl { | |||
| username: username.map(Into::into), | |||
| password: password.map(Into::into), | |||
| host: host.map(Into::into), | |||
| port: port.map(Into::into), | |||
| port, | |||
There was a problem hiding this comment.
linting fix due to new clippy version :)
davidhewitt
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't allow the application of the
strictconstraint toUniontypes inpydantic. We should defer to either the runtime strict specification or the union choice strict specification.strictcan either be specified at runtime via thestrictflag tomodel_validate_X, on a model's config, or on the union member type.This fixes pydantic/pydantic#10571 by reflecting that pattern in
pydantic-core.