-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gen_cluster failures; dask_version tweaks #5610
Conversation
Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-15 16:43:47 UTC |
Unit Test Results 6 files ±0 6 suites ±0 54m 25s ⏱️ ±0s For more details on these failures, see this check. Results for commit bc92331. ± Comparison against base commit bc92331. ♻️ This comment has been updated with latest results. |
You'll need a commit with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix and the clean-up, @crusaderky.
In case of temporary errors (such as the mamba
connection errors that sometimes appear) there is a "Rerun all jobs" button to rerun the workflow (it needs to either be cancelled or completed first, though). Closing and reopening works, too, but it reruns everything (including RTD) and the list of checks is extended.
the remaining error is the other one reported in #5600 so this should be ready to merge. Unless you want to add a "internals" |
I think it may be a bit overkill? |
distributed.utils_test.gen_cluster
no longer accepts timeout=None for the sake of robustnessdask.__version__