Switch to isort 5 #3724
Closed
Switch to isort 5 #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isort is already a dependency of pytest, there is no need to mention it explicitly. Except for the "formatting" environment where we want to pin a specific version to avoid noise when a new version of isort is released that reports errors.
|
I'll close this one in favor of #3725. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT: I found out (a bit too late) that isort 5 dropped the compatibility with Python 3.5 (which pylint still supports). So a better change could probably be to support isort 4 and isort 5. I did that in another pull request: #3725.
3 separate commits, the first two are:
adapt pylint to support isort 5 only. Because the API of isort 5 is completely new, the new code is NOT compatible with isort 4 anymore.
reorder pylint's own import statements to follow new isort 5 rules.
Type of Changes
Related Issue
Closes #3722
Steps