[duplicate-code] Ignore decorators lines by similarities checker when ignore signatures flag enabled #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Aug 13, 2021
ChangeLog
Outdated
Comment on lines
122
to
133
| What's New in Pylint 2.9.7? | ||
| =========================== | ||
| Release date: TBA | ||
|
|
||
| * Fix not ignored decorators lines by similarities checker when ignore signatures flag enabled | ||
|
|
||
| Closes #4839 | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| What's New in Pylint 2.9.7? | |
| =========================== | |
| Release date: TBA | |
| * Fix not ignored decorators lines by similarities checker when ignore signatures flag enabled | |
| Closes #4839 | |
| * Fix not ignored decorators lines by similarities checker when ignore signatures flag enabled | |
| Closes #4839 |
Next version will be 2.10.0 :)
There was a problem hiding this comment.
Changed, thanks!
Pierre-Sassoulas
added
Enhancement ✨
mhumetskyi
force-pushed
the
issue-4839
branch
2 times, most recently
from
1b5daf8 to
e6121a8
Compare
Pull Request Test Coverage Report for Build 1128773269
💛 - Coveralls |
… ignore signatures flag enabled
for more information, see https://pre-commit.ci
|
@Pierre-Sassoulas thanks for the quick feedback! I have updated PR according to labels (as it's not a bug but an enhancement). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Ignore function decorators during similarities check if ignore signatures flag enabled.
Closes #4839