Fix unused-import to checkdummy-variables-rgx
#8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8566 +/- ##
==========================================
- Coverage 95.91% 95.91% -0.01%
==========================================
Files 174 174
Lines 18370 18369 -1
==========================================
- Hits 17619 17618 -1
Misses 751 751
|
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
requested changes
Apr 12, 2023
That's what I figured as well! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
Resolve #8500 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 0cd41b1)
|
π€ Effect of this PR on checked open source code: π€ Effect on psycopg:
Effect on pytest:
This comment was generated for commit 53a8696 |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Apr 12, 2023
Resolve #8500 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 0cd41b1) Co-authored-by: RSTdefg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fixed
unused-importso that it observes thedummy-variables-rgxoption. Also added one testcase to test this behavior.Closes #8500