Draft: Improve Deno compatibility (v2) #3428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
commented
Jan 5, 2023
| ); | ||
| (globalThis as any).XMLHttpRequest = XHRModule.default; | ||
|
|
||
| let denoStdlib = "https://deno.land/[email protected]/"; |
There was a problem hiding this comment.
@josephrocca just curious, in your experience, is it OK to hardcode the stdlib version used this way in libraries in Deno, or is there a better packaging solution?
hoodmane
reviewed
Jan 5, 2023
| @@ -8,10 +8,14 @@ export const IN_NODE = | |||
| typeof process.browser === | |||
| "undefined"; /* This last condition checks if we run the browser shim of process */ | |||
|
|
|||
| export const IN_DENO = "Deno" in window; | |||
There was a problem hiding this comment.
Some people have requested a loadPyodide "runtime" argument that can override the automatic feature detection. It might be a bit annoying to set up though.
|
Closing in favor of #3420 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3421 bit with more code reuse from the Node.js implementation.
Not ready for a review yet.