Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with absolute path with Python 3.13 on Windows #302

Merged
merged 9 commits into from
Jan 4, 2025
Merged

Fix issue with absolute path with Python 3.13 on Windows #302

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
464735f
Fix issue with absolute path with Python 3.13 on Windows
adang1345 Oct 8, 2024
edfd6d2
Collapse startswith operations
jaraco Dec 27, 2024
b72fce6
Merge branch 'main' into fix-python313-abs
jaraco Jan 4, 2025
d13d5a7
👹 Feed the hobgoblins (delint).
jaraco Jan 4, 2025
1400152
Extract a classmethod _make_out_path_exts suitable for isolated testing.
jaraco Jan 4, 2025
b16c1de
Re-write _make_relative to rely on pathlib for cross-platform and cro…
jaraco Jan 4, 2025
57152cf
Move suppress_path_mangle to test_ccompiler to limit the scope.
jaraco Jan 4, 2025
ede1af2
Add tests and fix failure identified in the tests.
jaraco Jan 4, 2025
36ce8b3
Refactor for simplicity.
jaraco Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion distutils/ccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,8 @@ def _make_relative(base):
# Chop off the drive
no_drive = os.path.splitdrive(base)[1]
# If abs, chop off leading /
return no_drive[os.path.isabs(no_drive) :]
is_abs = os.path.isabs(no_drive) or sys.platform == 'win32' and (no_drive.startswith('/') or no_drive.startswith('\\'))
return no_drive[is_abs:]

def shared_object_filename(self, basename, strip_dir=False, output_dir=''):
assert output_dir is not None
Expand Down
Loading