Allowing prereleases for one SpecifierSet allows for all. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We erronously tried to let the underlying Specifiers handle the choice about if we are accepting pre-releases or not, however within a single SpecifierSet we need to consistently either allow pre-releases or not. This will cause any pre-release allowing specifier to cause the whole specifier set to allow pre-releases.
dstufft
force-pushed
the
fix-prereleases
branch
from
25abd92 to
c31e3e6
Compare
dstufft
added a commit
that referenced
this pull request
Apr 15, 2015
Allowing prereleases for one SpecifierSet allows for all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We erronously tried to let the underlying Specifiers handle the choice about if we are accepting pre-releases or not, however within a single SpecifierSet we need to consistently either allow pre-releases or not. This will cause any pre-release allowing specifier to cause the whole specifier set to allow pre-releases.
Fixes #28