Simplify _should_build #13232
Open
Simplify _should_build #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only call sites are in pip install in pip wheel, after resolution, so there are never constraint requirements there.
In pip wheel, we always want wheels, of course. should_build_for_wheel_command was only called when is_wheel is False, so the logging statement part of _should_build was never reached. Since this is the only side effect and _should_build otherwise always return true in these circumstances, it can be removed.
The need_wheel argument is now always False
sbidoul
added
skip news
It is a remnant of the `setup.py install` era, and we can safely assume it is always set.
|
I think |
notatallshaw
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suite of simple commits to simplify
_should_build, as the circumstances in which it is invoked have evolved over time.Each individual commit explains the reasoning.
towards #11457