Fix resolution of direct url subdependencies

- Fix resolution of direct url VCS subdependencies (e.g. top level dep depends on a VCS direct url subdependency) which rely on subdirectory resolution - Fixes #3976 Signed-off-by: Dan Ryan <[email protected]>
pypa · May 19, 2020 · 5df5282 · 5df5282
1 parent 9757dbf
commit 5df5282
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/news/3976.bugfix.rst b/news/3976.bugfix.rst
@@ -0,0 +1 @@
+Fixed a bug which prevented resolution of direct URL dependencies which have PEP508 style direct url VCS sub-dependencies with subdirectories.
diff --git a/pipenv/utils.py b/pipenv/utils.py
@@ -997,6 +997,8 @@ def clean_results(self):
         for req, ireq in reqs:
             if (req.vcs and req.editable and not req.is_direct_url):
                 continue
+            elif req.normalized_name in self.skipped.keys():
+                continue
             collected_hashes = self.collect_hashes(ireq)
             req = req.add_hashes(collected_hashes)
             if not collected_hashes and self._should_include_hash(ireq):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed a bug which prevented resolution of direct URL dependencies which have PEP508 style direct url VCS sub-dependencies with subdirectories.