Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4279: Stop test_ssh_vcs_install from failing #4280

Merged
merged 2 commits into from
May 29, 2020

Conversation

GPHemsley
Copy link
Contributor

Remove expectation of version key in test_ssh_vcs_install to
stop it from failing.

Mirrors similar change to test_git_vcs_install in
243b4fd.

Thank you for contributing to Pipenv!

The issue

Fixes #4279.

The fix

Mirror 243b4fd.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Remove expectation of `version` key in `test_ssh_vcs_install` to
stop it from failing.

Mirrors similar change to `test_git_vcs_install` in
243b4fd.
@techalchemy techalchemy added Category: Tests Relates to tests. Category: VCS Relates to version control system dependencies. PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. labels May 29, 2020
Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me!

@techalchemy techalchemy merged commit b5becd8 into pypa:master May 29, 2020
@GPHemsley GPHemsley deleted the issue-4279 branch May 29, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tests Relates to tests. Category: VCS Relates to version control system dependencies. PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_ssh_vcs_install failing due to version key mismatch
2 participants