Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_version(): normalize=False incompatible with several version schemes #1018

Closed
christian-herber-nxp opened this issue Feb 28, 2024 · 1 comment · Fixed by #1020
Closed
Labels

Comments

@christian-herber-nxp
Copy link

christian-herber-nxp commented Feb 28, 2024

running anything that calls this function with
-release-branch-semver
-python-simplified-semver

an error is thrown:

e.g. ValueError: <ScmVersion v2.0.0 dist=0 node=g17520db dirty=True branch=branch-name> can't be parsed as numeric version

@RonnyPfannschmidt
Copy link
Contributor

the issue is with the simplified parsing in guess_next_simple_semver

fortunately these days the version class is available and allows better parsing

RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Mar 5, 2024
RonnyPfannschmidt added a commit that referenced this issue Mar 5, 2024
…rmalized-semver

fix #1018 allow non normalized semver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants